[asterisk-dev] [Code Review] Make fax modules log debug messages to a "FAX" logger level.

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/658/#review1996
-----------------------------------------------------------



/trunk/include/asterisk/res_fax.h
<https://reviewboard.asterisk.org/r/658/#comment4228>

    Suggestion: make this function accept a 'default' level, that will be returned if no dynamic level was registered. That way the caller of this function can just pass in LOG_VERBOSE, LOG_DEBUG, etc. and get either the dynamic level or the passed-in level back, so the logic will live just in this function.



/trunk/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/658/#comment4227>

    This logic appears to be backwards.


- Kevin


On 2010-05-10 15:12:40, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/658/
> -----------------------------------------------------------
> 
> (Updated 2010-05-10 15:12:40)
> 
> 
> Review request for Asterisk Developers, Kevin Fleming and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Pretty simple. All fax-related messages from spandsp that previously went to the DEBUG logger level will be logged to a FAX logger level if possible.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/res_fax.h 262241 
>   /trunk/res/res_fax.c 262241 
>   /trunk/res/res_fax_spandsp.c 262241 
> 
> Diff: https://reviewboard.asterisk.org/r/658/diff
> 
> 
> Testing
> -------
> 
> It compiles. If someone wishes to run a fax using res_fax_spandsp with this patch and let me know if the messages are logged to the FAX channel properly, that would be great.
> 
> 
> Thanks,
> 
> Mark
> 
>