[asterisk-dev] [Code Review] VoicemailMain and VMauthenticate: Like VoiceMail allow escape to the 'a' extension when a single '*' is entered in Mailbox or Password

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/489/#review1985
-----------------------------------------------------------

Ship it!


Recommended changes made, looks good!

- Jeff


On 2010-05-07 17:59:30, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/489/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 17:59:30)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> VoiceMail() already has the ability to escape to the single digit 'a' extension.
> 
> Where a site uses VoiceMailMain(mailbox), the users have to be at their own extension to clear their voicemail, they have no way of escaping VoiceMailMain to allow entering there own mailbox.
> There are other reasons to require escape also.
> 
> The only option currently is to dial another number where VoiceMailMain() is called without the mailbox parmeter, and asks for Mailbox and Password.
> 
> This patch, allows a site to include to 'a' extension in the current dialplan context, to allow an escape.
> 
> If the 'a' priority doesn't exist in the context VoicemailMain is called from, then it acts as the old behaviour.
> 
> 
> Diffs
> -----
> 
>   /trunk/UPGRADE.txt 262004 
>   /trunk/apps/app_voicemail.c 262004 
> 
> Diff: https://reviewboard.asterisk.org/r/489/diff
> 
> 
> Testing
> -------
> 
> Tested both VoiceMailMain and VMauthenticate with the 'a' extension present and not. All 4 senarios performed as expected.
> Using the following dialplan:
> 
> [voicemail-main]
> exten => s,1,Answer()
> 
> exten => s,n,VMAuthenticate()
> exten => s,n,VoiceMailMain()
> exten => s,n,Verbose(0,After VoiceMailMain)
> exten => s,n,Hangup
> 
> exten => a,1,Verbose(0,User entered *)
> exten => a,n,Playback(connecting)
> exten => a,n,Goto(s,1)
> 
> 
> Thanks,
> 
> Alec
> 
>