[asterisk-dev] [Code Review] Parsing of reg->username containing @domain

[Nick Lewis]

> On 2010-05-05 13:46:29, David Vossel wrote:
> > trunk/main/app.c, lines 1196-1204
> > <https://reviewboard.asterisk.org/r/628/diff/5/?file=9981#file9981line1196>
> >
> >     Don't you just want to make sure the array is initialized here regardless if buf == NULL or not?  if so it's as simple as this.
> >     
> >     if (!array || !arraylen) {
> >         return 0;
> >     }
> >     memset(array, 0, arraylen * sizeof(*array));
> >     if (!buf) {
> >         return 0;
> >     }
> >     
> >

Yes this is much simpler thanks


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/628/#review1971
-----------------------------------------------------------


On 2010-05-05 05:46:44, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/628/
> -----------------------------------------------------------
> 
> (Updated 2010-05-05 05:46:44)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> reg->username is parsed for each registration refresh rather than once on sip reload. A previously committed change that addressed this was reverted because it did not cater for registration strings that contained a peer name in the host field. This change does. 
> 
> 
> This addresses bug 14331.
>     https://issues.asterisk.org/view.php?id=14331
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 258227 
>   trunk/channels/sip/config_parser.c 258227 
>   trunk/channels/sip/include/sip.h 258228 
>   trunk/main/app.c 258227 
> 
> Diff: https://reviewboard.asterisk.org/r/628/diff
> 
> 
> Testing
> -------
> 
> Passes a new unit test for parsing usernames containing domains. Passes existing unit tests. Passes peername functional test with sip.conf snippet
> 
> [general]
> register=nick at quirk
> [quirk]
> fromdomain=10.10.235.48
> 
> 
> Thanks,
> 
> Nick
> 
>