[asterisk-dev] [Code Review] ETSI Malicious Call ID (Asterisk component)

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/576/#review1961
-----------------------------------------------------------

Ship it!


- Russell


On 2010-03-26 10:48:57, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/576/
> -----------------------------------------------------------
> 
> (Updated 2010-03-26 10:48:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the ability to report malicious callers as an AMI event in the call event class.
> 
> Relevant specification: EN 300 180
> 
> The libpri portion of this review is located in review:
> https://reviewboard.asterisk.org/r/575/
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 254974 
>   /trunk/channels/sig_pri.h 254974 
>   /trunk/channels/sig_pri.c 254974 
>   /trunk/configure.ac 254974 
>   /trunk/include/asterisk/channel.h 254974 
>   /trunk/main/channel.c 254974 
>   /trunk/mcid_events.txt PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/576/diff
> 
> 
> Testing
> -------
> 
> Report call while connected.
> Report call after caller hangs up.
> 
> Comments about the format of the MCID events are also requested.
> The following is a sample of the events generated:
> 
> This event was generated when the caller was connected.
> 
> Event: MCID
> Privilege: call,all
> Channel: DAHDI/i2/400-d
> UniqueID: 1268949315.44
> CallerIDPres: 0 (Presentation Allowed, Not Screened)
> CallerIDNum: 200
> CallerIDton: 33
> CallerIDName:
> CallerIDSubaddr: 54321
> CallerIDSubaddrType: 2
> CallerIDSubaddrOdd: 1
> ConnectedIDPres: 0 (Presentation Allowed, Not Screened)
> ConnectedIDNum: 400
> ConnectedIDton: 0
> ConnectedIDName:
> 
> This event was generated after the caller disconnected and before the
> answerer hung up.  Since the Asterisk channel has already been destroyed
> we have to rely on information that libpri can supply.  This information
> may be incomplete if the upper layer (Asterisk) redacted some caller
> information because it was restricted.
> 
> Event: MCID
> Privilege: call,all
> CallerIDPres: 0 (Presentation Allowed, Not Screened)
> CallerIDNum: 200
> CallerIDton: 33
> CallerIDName:
> CallerIDSubaddr: 54321
> CallerIDSubaddrType: 2
> CallerIDSubaddrOdd: 1
> ConnectedIDPres: 0 (Presentation Allowed, Not Screened)
> ConnectedIDNum: 400
> ConnectedIDton: 0
> ConnectedIDName:
> 
> 
> Thanks,
> 
> rmudgett
> 
>