[asterisk-dev] [Code Review] External test for verifying SIP-related CHANNEL parameters

[Mark Michelson]

> On 2010-03-31 08:03:51, Matthew Nicholson wrote:
> > /asterisk/trunk/tests/sip_channel_params/test.lua, lines 56-77
> > <https://reviewboard.asterisk.org/r/589/diff/2/?file=8911#file8911line56>
> >
> >     You don't need the asynchronous response processing here.  You could execute the manager by doing "local r, err = m(getvar)" and then do all of your response processing on r and skip the calls to wait_response() and process_responses().  This would make the code a little more readable.

All right I have made this change.

In addition, I also have made the table of values and variables a parameter of the test_call function. This will allow easier expansion in case we want to add more test calls to the scenario in the future. I have ensured that the test still passes with these changes.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/589/#review1778
-----------------------------------------------------------


On 2010-03-25 11:48:39, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/589/
> -----------------------------------------------------------
> 
> (Updated 2010-03-25 11:48:39)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The summary says it nicely. In this test, a SIPp client calls Asterisk. While on the call, the lua script will connect to Asterisk via AMI and query the values of SIP-related parameters to the CHANNEL dialplan function.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/sip_channel_params/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_channel_params/configs/rtp.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_channel_params/configs/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip_channel_params/run-test PRE-CREATION 
>   /asterisk/trunk/tests/sip_channel_params/sipp/call.xml PRE-CREATION 
>   /asterisk/trunk/tests/sip_channel_params/sipp/register.xml PRE-CREATION 
>   /asterisk/trunk/tests/sip_channel_params/test.lua PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/589/diff
> 
> 
> Testing
> -------
> 
> I have run this test many times and have ensured that the results are correct.
> 
> 
> Thanks,
> 
> Mark
> 
>