[asterisk-dev] [Code Review] Add "auto-pause" capability to pause the "auto-paused" interface in all queues which it belongs.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/581/#review1775
-----------------------------------------------------------

Ship it!


Very nice patch! The only problems I can find are related to coding guidelines. Aside from what is noted below, this is good to go. Thanks!


trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/581/#comment3856>

    Please place spaces before and after the '!='



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/581/#comment3857>

    Please place spaces before and after '=='



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/581/#comment3855>

    Red areas such as these indicate trailing whitespace or inconsistent use of whitespace. Please fix these.


- Mark


On 2010-03-24 10:48:27, jlpedrosa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/581/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 10:48:27)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This a patch so queue auto-pause, pauses the member in all queue that member belongs not only in the queue the timeout took place.
> 
> Agent 1 logged in queue A
> Agent 1 Logged in queue B
> 
> A rna (ring no anwer) or timeout happens on queue A with agent 1. Before this patch it is being only paused on Queue A, Now in A and B.
> 
> It's a config file parameter, moving from autopause in queue from, yes|no, to yes|no|all.
> 
> Thanks 
> 
> 
> This addresses bug https://issues.asterisk.org/view.php?id=17008.
>     https://issues.asterisk.org/view.php?id=https://issues.asterisk.org/view.php?id=17008
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 253708 
>   trunk/configs/queues.conf.sample 253708 
> 
> Diff: https://reviewboard.asterisk.org/r/581/diff
> 
> 
> Testing
> -------
> 
> All testings if've done worked and it's taking care of old values
> 
> 
> Thanks,
> 
> jlpedrosa
> 
>