[asterisk-dev] [Code Review] menuselect: add an --enable-all and --disable-all command line flags

Kevin Fleming kpfleming at digium.com
Wed Mar 24 15:55:06 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/587/#review1742
-----------------------------------------------------------

Ship it!


Sneaky use of '^'.

- Kevin


On 2010-03-24 15:42:52, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/587/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 15:42:52)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Similar to the flags added by russellb, this adds --enable-all and --disable-all to menuselect to either enable all available options or disable them all.
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect.c 727 
> 
> Diff: https://reviewboard.asterisk.org/r/587/diff
> 
> 
> Testing
> -------
> 
> Ran `menuselect --enable-all menuselect.makeopts` and `menuselect --disable-all menuselect.makeopts` followed by 'menuselect menuselect.makeopts' to verify it enabled and disabled everything.
> 
> 
> Screenshots
> -----------
> 
> menuselect
>   https://reviewboard.asterisk.org/r/587/s/2/
> 
> 
> Thanks,
> 
> Sean
> 
>




More information about the asterisk-dev mailing list