[asterisk-dev] [Code Review] remove unneeded explicit specification of channel in dahdi ioctls

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/584/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Several DAHDI ioctls allow passing the channel numbers explicitly through one of the fields in the struct that is passed in the system call. This will override the actual file descriptor used. In some cases this is really needed. But in most cases it merely opens the door to unexpected bugs.

This patch removes a few such calls in Asterisk while not actually changing the behavior. The gain setting functions passed around a channel which is always 0, and thus this parameter is simply dropped.


Diffs
-----

  /trunk/channels/chan_dahdi.c 254360 

Diff: https://reviewboard.asterisk.org/r/584/diff


Testing
-------

So far: minimal: Does not seem to break anything here.


Thanks,

Tzafrir