[asterisk-dev] [Code Review] data api gsoc2009

[Eliel Sardañons]

> On 2010-03-23 11:35:54, Russell Bryant wrote:
> > /trunk/apps/app_queue.c, lines 7627-7630
> > <https://reviewboard.asterisk.org/r/275/diff/18/?file=8824#file8824line7627>
> >
> >     If these macros are a part of the public API, they need an AST_ prefix

They aren't, the name is randomly chosen to identify the structure.


> On 2010-03-23 11:35:54, Russell Bryant wrote:
> > /trunk/tests/test_data.c, lines 16-25
> > <https://reviewboard.asterisk.org/r/275/diff/18/?file=8836#file8836line16>
> >
> >     Will you convert this to the unit test API?

Ok, let me see how the test API works


- Eliel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/275/#review1723
-----------------------------------------------------------


On 2010-03-19 16:20:39, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/275/
> -----------------------------------------------------------
> 
> (Updated 2010-03-19 16:20:39)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This is the first review request for the Data API GSoC 2009 project.
> An architectural review is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 253535 
>   /trunk/apps/app_queue.c 253535 
>   /trunk/apps/app_voicemail.c 253535 
>   /trunk/doc/manager_1_1.txt 253535 
>   /trunk/include/asterisk/_private.h 253535 
>   /trunk/include/asterisk/channel.h 253535 
>   /trunk/include/asterisk/data.h PRE-CREATION 
>   /trunk/include/asterisk/doxyref.h 253535 
>   /trunk/include/asterisk/xml.h 253535 
>   /trunk/main/asterisk.c 253535 
>   /trunk/main/channel.c 253535 
>   /trunk/main/data.c PRE-CREATION 
>   /trunk/main/xml.c 253535 
>   /trunk/tests/test_data.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/275/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>