[asterisk-dev] [Code Review] Ensure line terminators for emails are consistent

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/544/#review1720
-----------------------------------------------------------



/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/544/#comment3796>

    Is there a reason not to use ast_safe_system() instead of doing all of this sigchld handling manually?



/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/544/#comment3798>

    Why aren't these cases test failures?



/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/544/#comment3797>

    Should we force the test not to run if IMAP_STORAGE is on, then?


- Russell


On 2010-03-08 19:03:35, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/544/
> -----------------------------------------------------------
> 
> (Updated 2010-03-08 19:03:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, for every backend other than IMAP, the line terminators for email notifications of voicemail are properly "\n", except within the attachments, which are "\r\n".  This confuses certain mailers.
> 
> 
> This addresses bug 16557.
>     https://issues.asterisk.org/view.php?id=16557
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 251395 
> 
> Diff: https://reviewboard.asterisk.org/r/544/diff
> 
> 
> Testing
> -------
> 
> Unit test written and run to verify behavior.
> 
> 
> Thanks,
> 
> Tilghman
> 
>