[asterisk-dev] [Code Review] Mask arguments of previous invocations of Gosub

Tilghman Lesher tlesher at digium.com
Tue Mar 16 18:46:55 CDT 2010



> On 2010-03-16 18:20:29, Russell Bryant wrote:
> > /trunk/tests/test_gosub.c, line 21
> > <https://reviewboard.asterisk.org/r/561/diff/1/?file=8698#file8698line21>
> >
> >     copy/paste error

Oops.  It's actually not a copy/paste error, but something I merely missed after copying the test_time.c file over.


> On 2010-03-16 18:20:29, Russell Bryant wrote:
> > /trunk/tests/test_gosub.c, line 23
> > <https://reviewboard.asterisk.org/r/561/diff/1/?file=8698#file8698line23>
> >
> >     I don't think the verbatim stuff is needed
> 
> Mark Michelson wrote:
>     The verbatim stuff needs to be removed from test_skel.c and app_skel.c. That's why so many people include this when submitting new code.

If it's not needed, then it probably should not be in the app_skel.c source, either, which is the original source for those tags.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/561/#review1692
-----------------------------------------------------------


On 2010-03-16 17:45:49, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/561/
> -----------------------------------------------------------
> 
> (Updated 2010-03-16 17:45:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The current behavior of Gosub is that it does not mask out previous arguments.  The problem with this is that for any subroutine with optional arguments, arguments from previous stack levels could influence how the newest stack level executes.
> 
> 
> This addresses bug 16758.
>     https://issues.asterisk.org/view.php?id=16758
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_stack.c 252838 
>   /trunk/tests/test_gosub.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/561/diff
> 
> 
> Testing
> -------
> 
> Unit test written that verifies this new behavior, as well as verifying several other behaviors of the Gosub suite of applications.
> 
> 
> Thanks,
> 
> Tilghman
> 
>




More information about the asterisk-dev mailing list