[asterisk-dev] [Code Review] Launchd property list for Mac OS X

[Tilghman Lesher]

> On 2010-03-14 15:59:06, Olle E Johansson wrote:
> > Suggestion: Change safe_asterisk to start with launchd.
> > 
> > Otherwise I think this is a very welcome addition. Thank you, Tilghman!

In fact, launchd will restart the Asterisk process itself, should it exit abnormally.  So the point of using safe_asterisk is negated by the very behavior of launchd.  The only other thing I was thinking about was to add aliases, in the form of /etc/init.d files, to start and stop Asterisk, through the documented launchctl calls.


> On 2010-03-14 15:59:06, Olle E Johansson wrote:
> > /branches/1.4/Makefile, line 695
> > <https://reviewboard.asterisk.org/r/551/diff/2/?file=8565#file8565line695>
> >
> >     IS there really any point of adding DESTDIR here? Would it work in any other directory... Just guessing here, but I suspect it only works in /Library and the user's ~Library

The point of it would be if you're managing a farm of Asterisk servers, and you directed DESTDIR to be a mountpoint for multiple servers.


> On 2010-03-14 15:59:06, Olle E Johansson wrote:
> > /branches/1.4/contrib/init.d/org.asterisk.asterisk.plist, line 36
> > <https://reviewboard.asterisk.org/r/551/diff/2/?file=8566#file8566line36>
> >
> >     This is a very low number of open files for an Asterisk VoIP server. The safe asterisk script usually sets this to a very high level.

The point of this was not to set the value to any particular value, but merely to exist as a reference point for administrators to set their own levels.  I wanted to create a property list that could be used by others to adjust most tweakable settings.  There are others, of course, but they mostly require substantial changes within Asterisk.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/551/#review1668
-----------------------------------------------------------


On 2010-03-14 15:23:57, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/551/
> -----------------------------------------------------------
> 
> (Updated 2010-03-14 15:23:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Create a property list for launching Asterisk on Mac OS X.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/Makefile 248857 
>   /branches/1.4/contrib/init.d/org.asterisk.asterisk.plist PRE-CREATION 
>   /branches/1.4/main/asterisk.c 248859 
> 
> Diff: https://reviewboard.asterisk.org/r/551/diff
> 
> 
> Testing
> -------
> 
> Verified to work under 10.6.2.
> 
> 
> Thanks,
> 
> Tilghman
> 
>