[asterisk-dev] [Code Review] Launchd property list for Mac OS X

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/551/#review1668
-----------------------------------------------------------

Ship it!


Suggestion: Change safe_asterisk to start with launchd.

Otherwise I think this is a very welcome addition. Thank you, Tilghman!


/branches/1.4/Makefile
<https://reviewboard.asterisk.org/r/551/#comment3733>

    IS there really any point of adding DESTDIR here? Would it work in any other directory... Just guessing here, but I suspect it only works in /Library and the user's ~Library



/branches/1.4/contrib/init.d/org.asterisk.asterisk.plist
<https://reviewboard.asterisk.org/r/551/#comment3734>

    This is a very low number of open files for an Asterisk VoIP server. The safe asterisk script usually sets this to a very high level.


- Olle E


On 2010-03-14 15:23:57, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/551/
> -----------------------------------------------------------
> 
> (Updated 2010-03-14 15:23:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Create a property list for launching Asterisk on Mac OS X.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/Makefile 248857 
>   /branches/1.4/contrib/init.d/org.asterisk.asterisk.plist PRE-CREATION 
>   /branches/1.4/main/asterisk.c 248859 
> 
> Diff: https://reviewboard.asterisk.org/r/551/diff
> 
> 
> Testing
> -------
> 
> Verified to work under 10.6.2.
> 
> 
> Thanks,
> 
> Tilghman
> 
>