[asterisk-dev] [Code Review] enable/disable options in menuselect from command line

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/550/#review1663
-----------------------------------------------------------

Ship it!


Looks good to me.

- Sean


On 2010-03-11 17:52:25, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/550/
> -----------------------------------------------------------
> 
> (Updated 2010-03-11 17:52:25)
> 
> 
> Review request for Asterisk Developers and Sean Bright.
> 
> 
> Summary
> -------
> 
> This update to menuselect allows you to make modifications to the menuselect.makeopts file from a script without using something like sed.  For automated testing, I want a script to be able to turn on the test framework and all test modules that have their dependencies met.  With this, it is very easy to do.
> 
> $ make menuselect.makeopts
> $ menuselect/menuselect --enable TEST_FRAMEWORK menuselect.makeopts
> $ menuselect/menuselect --enable-category MENUSELECT_TEST menuselect.makeopts
> 
> 
> Diffs
> -----
> 
>   /trunk/README 724 
>   /trunk/menuselect.c 724 
> 
> Diff: https://reviewboard.asterisk.org/r/550/diff
> 
> 
> Testing
> -------
> 
> I have tested the use case covered in the description and it works as expected.
> 
> 
> Thanks,
> 
> Russell
> 
>