[asterisk-dev] [Code Review] dial by name in chan_dahdi

[Tzafrir Cohen]

Hi,

Thanks for the review. Looking into your connects right now.

Some more general nits:

On Tue, Mar 02, 2010 at 07:24:05PM -0000, rmudgett at digium.com wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/535/#review1621
> -----------------------------------------------------------

> /trunk/channels/chan_dahdi.c
> <https://reviewboard.asterisk.org/r/535/#comment3627>
> 
>     Please add a doxygen function header comment.  You can use the dahdi_new_pri_nobch_channel() comment header as a template.

* Do I really have to tell doxygen that a static function is internal?
* Do I need to specify version (\since 1.8) for such an internal
  function?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir