[asterisk-dev] [Code Review] Fix for parking lot settings not being respected with unit test

Jeff Peeler jpeeler at digium.com
Tue Mar 2 20:47:45 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/539/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This verifies a change in parking to ensure the channel variable PARKINGLOT is respected. Kind of overkill for an obvious change, but many more parking scenarios can be added later.


This addresses bug 16592.
    https://issues.asterisk.org/view.php?id=16592


Diffs
-----

  /trunk/main/features.c 250288 

Diff: https://reviewboard.asterisk.org/r/539/diff


Testing
-------

Verified proposed fix works and that all created channels are properly destroyed. It seems though that I do actually have a ref count problem with the dynamic lot used for testing, which I haven't been able to track down yet. I went ahead and posted the review so the rest of the test can be examined.


Thanks,

Jeff




More information about the asterisk-dev mailing list