[asterisk-dev] [Code Review] ETSI Advice Of Charge (AOC) event reporting. (Asterisk component)

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/537/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This feature generates AMI events in the new aoc event class from the events passed up by libpri.

Relevant specification: EN 300 182

This is based off of asterisk/team/group/CCSS for improvements to handle non-call associated events.

The libpri portion of this review is located in review:
https://reviewboard.asterisk.org/r/538/


Diffs
-----

  /team/group/CCSS/CHANGES 249953 
  /team/group/CCSS/aoc_events.txt PRE-CREATION 
  /team/group/CCSS/channels/sig_pri.h 249953 
  /team/group/CCSS/channels/sig_pri.c 249953 
  /team/group/CCSS/configs/manager.conf.sample 249953 
  /team/group/CCSS/configure.ac 249953 
  /team/group/CCSS/include/asterisk/manager.h 249953 
  /team/group/CCSS/main/manager.c 249953 

Diff: https://reviewboard.asterisk.org/r/537/diff


Testing
-------

Created a modified version of libpri that generated many canned AOC messages when a call gets connected.  The AMI events generated are contained in the aoc_events.txt file in the review.

Comments about the format of the AOC events are also requested.
The following is a sample of the events generated:

Event: AOC-S
Privilege: aoc,all
Channel: DAHDI/i4/200-1
UniqueID: 1267209618.2
NumberRates: 2
Rate(0)/Chargeable: SupplementaryService
Rate(0)/Type: Flat
Rate(0)/Flat/Currency: Euros
Rate(0)/Flat/Amount/Cost: 4
Rate(0)/Flat/Amount/Multiplier: 1/100
Rate(1)/Chargeable: SupplementaryService
Rate(1)/Type: Volume
Rate(1)/Volume/Currency: Yen
Rate(1)/Volume/Amount/Cost: 300
Rate(1)/Volume/Amount/Multiplier: 100
Rate(1)/Volume/Unit: Message

Event: AOC-D
Privilege: aoc,all
Channel: DAHDI/i4/200-1
UniqueID: 1267209618.2
Type: Currency
BillingID: NotAvailable
TypeOfCharging: Total
Currency: Francs
Currency/Amount/Cost: 674
Currency/Amount/Multiplier: 1

The -1 values in this event indicate that the value was not present in the AOC message.
Event: AOC-D
Privilege: aoc,all
Channel: DAHDI/i4/200-1
UniqueID: 1267209618.2
Type: Units
BillingID: NotAvailable
TypeOfCharging: Total
Units/NumberItems: 2
Units/Item(0)/NumberOf: -1
Units/Item(0)/TypeOf: -1
Units/Item(1)/NumberOf: 8523
Units/Item(1)/TypeOf: 13

Event: AOC-E
Privilege: aoc,all
Channel: DAHDI/i4/200-1
UniqueID: 1267209618.2
ChargingAssociation/Number: 5551212
ChargingAssociation/Number/Plan: 0
Type: Free

This event came in without any call associated because there is no Channel or UniqueID header.
The -1 values in this event indicate that the value was not present in the AOC message.
Event: AOC-E
Privilege: aoc,all
ChargingAssociation/Number: 5398
ChargingAssociation/Number/Plan: 4
Type: Units
BillingID: CreditCard
Units/NumberItems: 1
Units/Item(0)/NumberOf: -1
Units/Item(0)/TypeOf: -1


Thanks,

rmudgett