[asterisk-dev] [Code Review] Out-of-tree modules can fail because of compiler flag differences.

[Jason Parker]

I posted review 508 last week but due to issues with my ReviewBoard account it 
wasn't sent to the list.

I'll give a summary here, and we can pretend this is a real review request.


https://reviewboard.asterisk.org/r/508/

When compiling modules out-of-tree, there is a large potential for ABI breakage, 
due to changing compiler flags.  If Asterisk is compiled with DEBUG_THREADS, and 
an out-of-tree module is not, it should not give undefined symbol errors during 
load (in fact, there's no reason it shouldn't work).  The biggest problem areas 
seemed to be DEBUG_THREADS and DEBUG_CHANNEL_LOCKS.

In theory, this patch should correct the problem.  It also ended up simplifying 
the API immensely.