[asterisk-dev] [Code Review] IPv6 in Asterisk

Mon Jun 28 15:37:42 CDT 2010

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/743/#review2296
-----------------------------------------------------------

Peer review, made it up to chan_sip.  Mostly CODING-GUIDELINES, plus a question about manager events.

/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/743/#comment4831>

    Braces around if statements.

/trunk/channels/chan_mgcp.c
<https://reviewboard.asterisk.org/r/743/#comment4832>

    Same as above.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4833>

    Space after if, and braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4834>

    same as above.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4835>

    Braces for if statements.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4836>

    same.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4837>

    Braces, since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4838>

    braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4839>

    braces for if statements.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4840>

    More braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4841>

    same.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4842>

    same.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4843>

    Braces since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4844>

    Space between if and (, plus braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4845>

    braces since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4846>

    Space between if and (.  Braces for if statements.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4847>

    Same, space between if and (

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4848>

    Braces since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4849>

    Again, braces since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4850>

    Same.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4851>

    Space between if and (, braces for if statements.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4852>

    same, spacing.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4853>

    spaceing

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4854>

    spacing

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4855>

    braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4856>

    Braces, since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4857>

    braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4858>

    same, braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4859>

    since we are here, braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4860>

    same

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4861>

    same

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4862>

    same

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4863>

    Braces, since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4864>

    same as above.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4865>

    braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4866>

    Braces for if statements.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4867>

    Braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4868>

    spacing between if and (

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4869>

    Braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4870>

    blob

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4871>

    blob

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4872>

    Braces, since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4873>

    This appears to be a change in behaviour for the manager event 'PeerStatus', was this intentional?

    We have dropped the 'Port' setting.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4874>

    spacing between + sign

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4875>

    Braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4876>

    Same.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4877>

    Braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4878>

    Again, this is a change in behaviour.  Do we need to be merging host and port?

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4879>

    Braces since we are here.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4880>

    spacing between if and (, braces for if statements.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4881>

    Braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4882>

    missing braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4883>

    braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4884>

    spacing and braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4885>

    blob

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4886>

    Hard-coded setting?

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4887>

    spacing

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4888>

    braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4889>

    again, braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4890>

    spacing and braces.

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4891>

    braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4892>

    Braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4893>

    Braces, and red blob

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4894>

    same comment

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4895>

    same

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4897>

    Does temporary still apply after porting?

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4896>

    Braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4898>

    blob

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4899>

    braces

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4900>

    remove space before ;

/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/743/#comment4901>

    braces

- pabelanger

On 2010-06-28 14:29:33, Simon Perreault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/743/
> -----------------------------------------------------------
> 
> (Updated 2010-06-28 14:29:33)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This is the port of Asterisk to IPv6.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 272684 
>   /trunk/apps/app_externalivr.c 272684 
>   /trunk/channels/chan_gtalk.c 272684 
>   /trunk/channels/chan_h323.c 272684 
>   /trunk/channels/chan_iax2.c 272684 
>   /trunk/channels/chan_jingle.c 272684 
>   /trunk/channels/chan_mgcp.c 272684 
>   /trunk/channels/chan_multicast_rtp.c 272684 
>   /trunk/channels/chan_sip.c 272684 
>   /trunk/channels/chan_skinny.c 272684 
>   /trunk/channels/chan_unistim.c 272684 
>   /trunk/channels/sip/dialplan_functions.c 272684 
>   /trunk/channels/sip/include/dialog.h 272684 
>   /trunk/channels/sip/include/globals.h 272684 
>   /trunk/channels/sip/include/reqresp_parser.h 272684 
>   /trunk/channels/sip/include/sip.h 272684 
>   /trunk/channels/sip/reqresp_parser.c 272684 
>   /trunk/include/asterisk/acl.h 272684 
>   /trunk/include/asterisk/config.h 272684 
>   /trunk/include/asterisk/dnsmgr.h 272684 
>   /trunk/include/asterisk/netsock2.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 272684 
>   /trunk/include/asterisk/tcptls.h 272684 
>   /trunk/main/acl.c 272684 
>   /trunk/main/app.c 272684 
>   /trunk/main/config.c 272684 
>   /trunk/main/dnsmgr.c 272684 
>   /trunk/main/http.c 272684 
>   /trunk/main/manager.c 272684 
>   /trunk/main/netsock2.c PRE-CREATION 
>   /trunk/main/rtp_engine.c 272684 
>   /trunk/main/tcptls.c 272684 
>   /trunk/res/res_rtp_asterisk.c 272684 
>   /trunk/res/res_rtp_multicast.c 272684 
> 
> Diff: https://reviewboard.asterisk.org/r/743/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Simon
> 
>