[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[Nick Lewis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2292
-----------------------------------------------------------



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4820>

    This is okay for reload but no good for initial load because the sql module loads after the sip module. Can the sql module be forced to load first? Can chan_sip.c subscribe to a notification of sql module loading and hook realtime_register onto it. 



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4821>

    A double free apparently. I guess peerlist and var must overlap



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4828>

    If these realtime sip_register objects suffer registration timeout then they proliferate in sip show registry - but why?


- Nick


On 2010-06-24 11:54:11, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-24 11:54:11)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
>   trunk/doc/tex/realtime.tex 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>