[asterisk-dev] [Code Review] IPv6 in Asterisk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/743/#review2282
-----------------------------------------------------------


This first set of comments addresses the first page of the diff, except for chan_sip.c. I also found a small spacing issue in netsock2.c when I was browsing through it. My next step will be to review chan_sip.c.

Note that since I did not review chan_sip.c yet, my comments in some of the supplementary SIP files, like reqresp_parser, may just be completely off.


/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/743/#comment4787>

    our_addr.sin_family is not set to AF_INET prior to the call to ast_sockaddr_from_sin(). This will cause a warning message to be printed in ast_sockaddr_from_sin(). I recommend setting the address family of ouraddr before the call to ast_sockaddr_from_sin.



/trunk/addons/chan_ooh323.c
<https://reviewboard.asterisk.org/r/743/#comment4788>

    1. These two lines should be swapped. You are setting a remote RTP instance address using an uninitialized ast_sockaddr.
    
    2. You should be calling ast_sockaddr_from_sin() instead of ast_sockaddr_to_sin().



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/743/#comment4789>

    You don't need the ast_sockaddr_from_sin() call here. For one thing, reg has just been allocated, so reg->addr is zeroed out. For another, reg_addr_tmp will be overwritten by the subsequent call to ast_dnsmgr_lookup().



/trunk/channels/sip/dialplan_functions.c
<https://reviewboard.asterisk.org/r/743/#comment4794>

    This is a lot less fun than the previous version :(
    
    Heh, no need to change it though ;)



/trunk/channels/sip/include/reqresp_parser.h
<https://reviewboard.asterisk.org/r/743/#comment4796>

    My same general comment for reqresp_parser.c applies to reqresp_parser.h. What relevance do these changes have?



/trunk/channels/sip/reqresp_parser.c
<https://reviewboard.asterisk.org/r/743/#comment4795>

    This comment really pertains to the entire reqresp_parser.c file, and not just this one portion.
    
    It seems that there were two widespread changes made:
    
    1. Change the word "host" to "domain"
    2. Remove individual port settings and add them to the end of the domain.
    
    I can't see what relevance this has to supporting IPv6 or the version-independent ast_sockaddr API. Is there something I'm missing?



/trunk/main/netsock2.c
<https://reviewboard.asterisk.org/r/743/#comment4786>

    You've got red on you.


- Mark


On 2010-06-25 09:02:18, Simon Perreault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/743/
> -----------------------------------------------------------
> 
> (Updated 2010-06-25 09:02:18)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This is the port of Asterisk to IPv6.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 272524 
>   /trunk/apps/app_externalivr.c 272524 
>   /trunk/channels/chan_gtalk.c 272524 
>   /trunk/channels/chan_h323.c 272524 
>   /trunk/channels/chan_iax2.c 272524 
>   /trunk/channels/chan_jingle.c 272524 
>   /trunk/channels/chan_mgcp.c 272524 
>   /trunk/channels/chan_multicast_rtp.c 272524 
>   /trunk/channels/chan_sip.c 272524 
>   /trunk/channels/chan_skinny.c 272524 
>   /trunk/channels/chan_unistim.c 272524 
>   /trunk/channels/sip/dialplan_functions.c 272524 
>   /trunk/channels/sip/include/dialog.h 272524 
>   /trunk/channels/sip/include/globals.h 272524 
>   /trunk/channels/sip/include/reqresp_parser.h 272524 
>   /trunk/channels/sip/include/sip.h 272524 
>   /trunk/channels/sip/reqresp_parser.c 272524 
>   /trunk/include/asterisk/acl.h 272524 
>   /trunk/include/asterisk/config.h 272524 
>   /trunk/include/asterisk/dnsmgr.h 272524 
>   /trunk/include/asterisk/netsock2.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 272524 
>   /trunk/include/asterisk/tcptls.h 272524 
>   /trunk/main/acl.c 272524 
>   /trunk/main/app.c 272524 
>   /trunk/main/config.c 272524 
>   /trunk/main/dnsmgr.c 272524 
>   /trunk/main/http.c 272524 
>   /trunk/main/manager.c 272524 
>   /trunk/main/netsock2.c PRE-CREATION 
>   /trunk/main/rtp_engine.c 272524 
>   /trunk/main/tcptls.c 272524 
>   /trunk/res/res_rtp_asterisk.c 272524 
>   /trunk/res/res_rtp_multicast.c 272524 
> 
> Diff: https://reviewboard.asterisk.org/r/743/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Simon
> 
>