[asterisk-dev] [Code Review] Backport unit test API to 1.6.2 branch

Russell Bryant russell at digium.com
Fri Jun 25 13:46:21 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/748/
-----------------------------------------------------------

Review request for Asterisk Developers and David Vossel.


Summary
-------

The unit test API has settled in trunk.  I'd like to now make it available in the release versions that we are still supporting so that we can add test code there, as well.  Since none of this code is enabled unless a build is done with TEST_FRAMEWORK enabled, it is extremely low risk for introducing problems into the release branches.

include/asterisk/test.h is unchanged from trunk.  main/test.c only received very trivial changes (removing const in a few places to match the 1.6.2 version of ast_cli_complete()).  I included the test example module, as well as updating the test modules that were there but had been updated to the test API already in trunk.


Diffs
-----

  /branches/1.6.2/build_tools/cflags-devmode.xml 272526 
  /branches/1.6.2/include/asterisk/_private.h 272526 
  /branches/1.6.2/include/asterisk/test.h PRE-CREATION 
  /branches/1.6.2/main/Makefile 272526 
  /branches/1.6.2/main/asterisk.c 272526 
  /branches/1.6.2/main/test.c PRE-CREATION 
  /branches/1.6.2/tests/test_heap.c 272526 
  /branches/1.6.2/tests/test_sched.c 272526 
  /branches/1.6.2/tests/test_skel.c 272526 

Diff: https://reviewboard.asterisk.org/r/748/diff


Testing
-------

I ran Asterisk with TEST_FRAMEWORK enabled and verified that "test show registered all" and "test execute all" generated the expected results.


Thanks,

Russell




More information about the asterisk-dev mailing list