[asterisk-dev] [Code Review] IPv6 in Asterisk

[Simon Perreault]

> On 2010-06-24 18:05:31, Russell Bryant wrote:
> > It looks like chan_h323 and chan_mgcp have not been updated to address API changes.

Yes. We modified the RTP API so that it takes struct ast_sockaddr instead of struct sockaddr_in as argument. All channels using the RTP API needed to be changed, but only chan_sip was "fully" changed so as to make it IPv6-enabled. Other channels that are still IPv4-only have been only slightly modified by adding casts when they call functions from the RTP API. This is the case for chan_h323 and chan_mgcp.


- Simon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/743/#review2276
-----------------------------------------------------------


On 2010-06-24 18:00:19, Simon Perreault wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/743/
> -----------------------------------------------------------
> 
> (Updated 2010-06-24 18:00:19)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This is the port of Asterisk to IPv6.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 272442 
>   /trunk/apps/app_externalivr.c 272442 
>   /trunk/channels/chan_gtalk.c 272442 
>   /trunk/channels/chan_iax2.c 272442 
>   /trunk/channels/chan_jingle.c 272442 
>   /trunk/channels/chan_mgcp.c 272442 
>   /trunk/channels/chan_multicast_rtp.c 272442 
>   /trunk/channels/chan_sip.c 272442 
>   /trunk/channels/chan_skinny.c 272442 
>   /trunk/channels/chan_unistim.c 272442 
>   /trunk/channels/sip/dialplan_functions.c 272442 
>   /trunk/channels/sip/include/dialog.h 272442 
>   /trunk/channels/sip/include/globals.h 272442 
>   /trunk/channels/sip/include/reqresp_parser.h 272442 
>   /trunk/channels/sip/include/sip.h 272442 
>   /trunk/channels/sip/reqresp_parser.c 272442 
>   /trunk/include/asterisk/acl.h 272442 
>   /trunk/include/asterisk/config.h 272442 
>   /trunk/include/asterisk/dnsmgr.h 272442 
>   /trunk/include/asterisk/netsock2.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 272442 
>   /trunk/include/asterisk/tcptls.h 272442 
>   /trunk/main/acl.c 272442 
>   /trunk/main/app.c 272442 
>   /trunk/main/config.c 272442 
>   /trunk/main/dnsmgr.c 272442 
>   /trunk/main/http.c 272442 
>   /trunk/main/manager.c 272442 
>   /trunk/main/netsock2.c PRE-CREATION 
>   /trunk/main/rtp_engine.c 272442 
>   /trunk/main/tcptls.c 272442 
>   /trunk/res/res_rtp_asterisk.c 272442 
>   /trunk/res/res_rtp_multicast.c 272442 
> 
> Diff: https://reviewboard.asterisk.org/r/743/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Simon
> 
>