[asterisk-dev] [Code Review] Expand the caller ANI field to an ast_party_id

[Klaus Darilion]

Hi Richard!

Should this patch already handle two Calling Number IEs? eg:

< [6c 0d 21 80 36 39 39 31 31 31 36 30 30 33 36]
< Calling Number (len=15) [ Ext: 0  TON: National Number (2)  NPI: 
ISDN/Telephony Numbering Plan (E.164/E.163) (1)
<                           Presentation: Presentation permitted, user 
number not screened (0)  '69911160036' ]
< [6c 08 21 83 31 32 35 33 39 37]
< Calling Number (len=10) [ Ext: 0  TON: National Number (2)  NPI: 
ISDN/Telephony Numbering Plan (E.164/E.163) (1)
<                           Presentation: Presentation allowed of 
network provided number (3)  '125397' ]

If yes, I can test if it works as expected.

regards
Klaus



Am 24.06.2010 23:22, schrieb rmudgett at digium.com:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/744/
> -----------------------------------------------------------
>
> Review request for Asterisk Developers and Mark Michelson.
>
>
> Summary
> -------
>
> Expand the ani field in ast_party_caller and ast_party_connected_line to
> an ast_party_id.
>
> This is an extension to the ast_callerid restructuring patch in review:
> https://reviewboard.asterisk.org/r/702/
>
> Note that the "XXX_" prepended to the name and number members in
> ast_party_id in the diff are to ensure that all code has been converted
> and will be renamed when committed.
>
>
> Diffs
> -----
>
>    /team/rmudgett/cid/apps/app_amd.c 272445
>    /team/rmudgett/cid/channels/chan_dahdi.c 272445
>    /team/rmudgett/cid/channels/chan_h323.c 272445
>    /team/rmudgett/cid/channels/chan_iax2.c 272445
>    /team/rmudgett/cid/channels/chan_jingle.c 272445
>    /team/rmudgett/cid/channels/chan_mgcp.c 272445
>    /team/rmudgett/cid/channels/chan_misdn.c 272445
>    /team/rmudgett/cid/channels/chan_oss.c 272445
>    /team/rmudgett/cid/channels/chan_phone.c 272445
>    /team/rmudgett/cid/channels/chan_sip.c 272445
>    /team/rmudgett/cid/channels/chan_skinny.c 272445
>    /team/rmudgett/cid/channels/chan_usbradio.c 272445
>    /team/rmudgett/cid/channels/chan_vpb.cc 272445
>    /team/rmudgett/cid/channels/sig_analog.c 272445
>    /team/rmudgett/cid/channels/sig_pri.c 272445
>    /team/rmudgett/cid/channels/sig_ss7.c 272445
>    /team/rmudgett/cid/funcs/func_callerid.c 272445
>    /team/rmudgett/cid/include/asterisk/channel.h 272445
>    /team/rmudgett/cid/main/cdr.c 272445
>    /team/rmudgett/cid/main/cel.c 272445
>    /team/rmudgett/cid/main/channel.c 272445
>    /team/rmudgett/cid/res/snmp/agent.c 272445
>
> Diff: https://reviewboard.asterisk.org/r/744/diff
>
>
> Testing
> -------
>
> Compile testing.  SIP and ISDN Q.SIG calls with CALLERID(ANI-xxx) values set and read.
>
>
> Thanks,
>
> rmudgett
>
>