[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[Nick Lewis]

> On 2010-06-23 14:42:49, David Vossel wrote:
> > trunk/configs/sip.conf.sample, lines 567-570
> > <https://reviewboard.asterisk.org/r/718/diff/4/?file=11012#file11012line567>
> >
> >     Does it make sense for this option to be called 'callbackexpiry'? or should it be something like 'registerexpiry'?
> 
> Nick Lewis wrote:
>     I think I agree with you (and oej). I was originally concerned that with the parameters
>     regexten
>     regexpiry
>     callbackexten
>     
>     the regexpiry parameter would be associated with regexten rather than callbackexten. Ideally regexten would be called autodialplan or something else without a reg or register prefix to limit confusion but I think it is okay.
>     
>     Another possibility is to make the register parameter like qualify i.e.
>     register=no
>     register=yes (3600 secs)
>     register=60
>     
>     What do you think?
> 
> David Vossel wrote:
>     I the idea of overloading the 'register' option to handle the expiry.  Just make sure to update the documentation with what the default expiry is if only 'yes' is used.  From the code it looks like the default is 120 seconds.
> 
> David Vossel wrote:
>     This is supposed to read, "I like the idea..."

120 seconds -  so it is - a bit slower than required to work behind nat and much faster than required to work without nat. I wonder how this value was chosen?

I have discovered that I am in fact an optimist as I misread it with "like" rather than "hate" / "spit on" / "cannot think of anything worse than"


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2255
-----------------------------------------------------------


On 2010-06-23 11:03:32, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-23 11:03:32)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>