[asterisk-dev] [Code Review] Save and reset the AST_FLAG_BRIDGE_HANGUP_DONT flag on attended transfer

tim.ringenbach at gmail.com tim.ringenbach at gmail.com
Wed Jun 23 16:45:34 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/741/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

ast_bridge_call() clears AST_FLAG_BRIDGE_HANGUP_DONT. But during an attended transfer, ast_bridge_call() is called for a second bridge on the same channel, and it clears that flag, which still needs to get set for when the original ast_bridge_call() gets control back and checks it.

Without this patch, the h extension would get run early in some cases. In order to see that, the transfer has to fail and then the original bridge has to end in a way that wouldn't normally run the h extension. The h exten ends up running early, and the not running when the call really hangs up.


Diffs
-----

  http://svn.asterisk.org/svn/asterisk/branches/1.4/res/res_features.c 271334 

Diff: https://reviewboard.asterisk.org/r/741/diff


Testing
-------

Tested with and without this patch on 1.4. Without it, the h exten gets called before the channel actually hangs up.


Thanks,

tim_ringenbach




More information about the asterisk-dev mailing list