[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/#review2241
-----------------------------------------------------------

Ship it!


Great work Jeff!  I had only one minor comment.


/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/673/#comment4747>

    If either of these container allocations fail, Asterisk might crash later if the session is allowed to continue, but it would be weird to fail the authentication because of an allocation error.
    
    I'd just move the container allocation to the "build_mansession()" function.  That way if either container fails to alloc, you can just cleanup and return NULL.


- David


On 2010-06-17 17:02:19, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2010-06-17 17:02:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From the submitter:
> to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).
> 
> 
> This addresses bug 14861.
>     https://issues.asterisk.org/view.php?id=14861
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 271297 
>   /trunk/configs/manager.conf.sample 271297 
>   /trunk/main/manager.c 271297 
> 
> Diff: https://reviewboard.asterisk.org/r/673/diff
> 
> 
> Testing
> -------
> 
> I ensured manager events are reported the same without filtering and works as expected with.
> 
> 
> Thanks,
> 
> Jeff
> 
>