[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[Nick Lewis]

> On 2010-06-16 12:09:20, David Vossel wrote:
> > First off, Thank you for doing this!  I've been wanting this option for awhile now and just haven't gotten the chance to work on it.  The code looks good.  I had a few minor comments but didn't find anything serious.
> > 
> > My main concern about this feature is making sure we get the documentation right.  Some of the new peer options you've added aren't documented in sip.conf.sample.  The tricky part about this feature is documenting it in a way that doesn't make registrations appear to be even more complicated than they already are.  I'm still not sure how this should be done.
> > 
> >
> 
> Nick Lewis wrote:
>     I will add the missing peer options to sip.conf.sample and work on making the description simpler. I would ideally like to make the default callbackexten the same as the peername so that registration is as simple as setting register=yes for 99% of applications
> 
> Mark Michelson wrote:
>     With this set of changes in place, would there ever be a need for someone to put an old style register line in their sip.conf file? I'm not suggesting that we remove the ability to have such lines in sip.conf, but if there is a better, more intuitive method of having Asterisk register with endpoints, then I argue that we can remove the documentation for the old method of sending registrations entirely. The facility would still be in place so that those who upgrade to 1.8 would not have to rewrite their configs, but the ability to do so would be completely undocumented, so that people who are using 1.8 for the first time won't be confused about the different methods and will be more inclined to use the newer, more intuitive method.

Yes I would be more than happy to remove all mention of the register string 
and perhaps instead add more on the relationship between sip.conf and extensions.conf with the simplest register setup e.g.

sip.conf:
...
[trunk1]
register=yes
...
[trunk2]
register=yes
...

extensions.conf:
...
exten = _9.,1,Dial(SIP/trunk1/${EXTEN:1})
exten = _8.,1,Dial(SIP/trunk2/${EXTEN:1})
exten = trunk1,1,Goto(sales,1)
exten = trunk2,1,Goto(support,1)


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2213
-----------------------------------------------------------


On 2010-06-17 10:01:52, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-17 10:01:52)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>