[asterisk-dev] [Code Review] Incorrect reloading of realtime peer causes mailbox list to expand indefinitely

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/666/
-----------------------------------------------------------

(Updated 2010-06-16 15:44:11.390545)


Review request for Asterisk Developers and Marquis.


Summary
-------

Posting this patch for review, it is marked as Major on the tracker and numerous people seem to be affected.

Copied from issue:
---
Due to the current code's inability to short-circuit the reloading of a realtime peer when it's looking for a user, the mailbox list is repeatedly appended to.

For example, if you issue a 'sip show peer 1234', you may get something like:
Mailbox : 1234 at default

But after any inbound peer match (resulting in a call to find_peer), it will result in:
Mailbox : 1234 at default, 1234 at default

And so on, ad infinitum.

This can cause a large number of NOTIFYs to be sent to the peer, in some cases resulting in a phone crash or reboot.

There may be other effects, but this is the observed behavior. 
---


This addresses bugs 16320, 17254 and 17313.
    https://issues.asterisk.org/view.php?id=16320
    https://issues.asterisk.org/view.php?id=17254
    https://issues.asterisk.org/view.php?id=17313


Diffs
-----

  /trunk/channels/chan_sip.c 264161 

Diff: https://reviewboard.asterisk.org/r/666/diff


Testing
-------

Marquis created the patch, and other reporters successfully running it.


Thanks,

pabelanger