[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2207
-----------------------------------------------------------


Simple peer review. Be sure to include the proper documentation for your new settings (see below), plus CHANGES and UPGRADE.txt.


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4705>

    These new values will need to be documented and updated within the sip.conf file.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4706>

    big ole red blob.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4707>

    same, red blobs.



trunk/channels/sip/include/sip.h
<https://reviewboard.asterisk.org/r/718/#comment4708>

    same as above.


- pabelanger


On 2010-06-16 03:44:50, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 03:44:50)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>