[asterisk-dev] [Code Review] Extend the max number of callgroups/pickupgroups

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/466/#review2205
-----------------------------------------------------------


Simple peer review for CODING-GUIDELINES.  Be sure to also include the proper documentation for the changes.


/trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment4682>

    Red blob



/trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment4683>

    Another red blob



/trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment4684>

    same as above.



/trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/466/#comment4685>

    Same as above



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/466/#comment4686>

    another



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/466/#comment4687>

    red blob, since we are here.



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/466/#comment4688>

    same



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/466/#comment4690>

    Doxygen your comments.



/trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/466/#comment4689>

    same as above.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4695>

    doxygen return values since we are here.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4691>

    indent



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4692>

    braces and red blob



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4696>

    same doxygen comment as above



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4694>

    spacing between variables.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4697>

    another blob.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4698>

    spacing



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4699>

    braces for if statements



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4700>

    Spacing between operators.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4701>

    same as above



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4702>

    same



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4703>

    remove ( )



/trunk/main/cli.c
<https://reviewboard.asterisk.org/r/466/#comment4704>

    another red blob.


- pabelanger


On 2010-06-15 17:16:09, raarts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/466/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 17:16:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently the number of callgroups/pickupgroups is limited to 63, because the variable type that holds the group bits is a long long.
> 
> Here's a patch that extends this variable to an arbitrary-length (determined at compile time) int array. It currently sets the max number of groups to 1024.
> It implements this for all channels, but I only tested SIP and DAHDI.
> 
> Some people might object to implementing this as an array of ints, because it introduces a loop. But I think call pickups are not done often enough for this to become a problem.
> 
> See https://issues.asterisk.org/view.php?id=16640
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dumpchan.c 241415 
>   /trunk/channels/chan_agent.c 241415 
>   /trunk/channels/chan_dahdi.c 241415 
>   /trunk/channels/chan_gtalk.c 241415 
>   /trunk/channels/chan_jingle.c 241415 
>   /trunk/channels/chan_mgcp.c 241415 
>   /trunk/channels/chan_misdn.c 241415 
>   /trunk/channels/chan_sip.c 241415 
>   /trunk/channels/chan_skinny.c 241415 
>   /trunk/channels/chan_unistim.c 241415 
>   /trunk/channels/misdn_config.c 241415 
>   /trunk/doc/asterisk-mib.txt 241415 
>   /trunk/funcs/func_channel.c 241415 
>   /trunk/include/asterisk/channel.h 241415 
>   /trunk/main/channel.c 241415 
>   /trunk/main/cli.c 241415 
>   /trunk/main/features.c 241415 
>   /trunk/res/snmp/agent.c 241415 
> 
> Diff: https://reviewboard.asterisk.org/r/466/diff
> 
> 
> Testing
> -------
> 
> This patch has been in our asterisk 1.2 for 3 years now without problems. I ported it over to 1.6.2 and tested it there. The patch uploaded here is against trunk which is currently being tested by a colleague of mine, but they are all basically the same patch. 
> 
> 
> Thanks,
> 
> raarts
> 
>