[asterisk-dev] [Code Review] sort=alpha does not start at first file
Mark Michelson
mmichelson at digium.com
Mon Jun 14 16:20:05 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/703/#review2199
-----------------------------------------------------------
Ship it!
Tested and it works as described. Good job!
- Mark
On 2010-06-14 13:55:28, pabelanger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/703/
> -----------------------------------------------------------
>
> (Updated 2010-06-14 13:55:28)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Leif reported this problem over IRC, I managed to find and fix the problem (as crazy as that sounds).
>
> Seems when you set sort=alpha, it would always play start + 1 file in the list first. We now check to see if it is the first time and if so, play the first file in the list.
>
>
> This addresses bug 17470.
> https://issues.asterisk.org/view.php?id=17470
>
>
> Diffs
> -----
>
> /trunk/res/res_musiconhold.c 266928
>
> Diff: https://reviewboard.asterisk.org/r/703/diff
>
>
> Testing
> -------
>
> Local development box and Leif
>
>
> Thanks,
>
> pabelanger
>
>
More information about the asterisk-dev
mailing list