[asterisk-dev] [Code Review] app_queue: Log failed attempts to call members

paul.belanger at polybeacon.com paul.belanger at polybeacon.com
Mon Jun 14 15:41:59 CDT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers and haakon.


haakon posted this patch on the issue tracker, I am simply reposting it to reviewboard.
This patch enables logging of all call attempts from a queue. Not only the ones that do not fail.

The patch also introduces a new parameter "congestion" to both RINGNOANSWER in queue_log and AgentRingNoAnswer AMI event, which is set to 1 if the call failed to go through because of technical difficulties.

This makes it easier to make queue_log statistics with information about problems with an agent. For example if an agent has a faulty line, or your telco/dahdi connection is having problems.

I am however unsure if everyone want this marked as an congestion from the "AST_CONTROL_CONGESTION" frame. Since in my experience, this can come if a SIP UA doesn't want to let you ring more than x seconds, etc. Most real congestion problems come before this frame is generated. (read: before a new channel is up at all) So if this patch should be applied, maybe it should be configurable, or let out. 

This addresses bug 16925.


  /trunk/apps/app_queue.c 270262 
  /trunk/doc/manager_1_1.txt 270262 
  /trunk/doc/tex/queuelog.tex 270262 

Diff: https://reviewboard.asterisk.org/r/704/diff


Updated patch to latest trunk, compiled and installed.



More information about the asterisk-dev mailing list