[asterisk-dev] [Code Review] SIP from-header is parsed twice

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/701/#review2192
-----------------------------------------------------------


A simple peer review :)


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/701/#comment4649>

    Might as well get the red blob since we are here.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/701/#comment4653>

    trivial but the function only returns 0



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/701/#comment4651>

    trivial, but an empty line in the comments.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/701/#comment4652>

    { on next line



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/701/#comment4650>

    missing braces


- pabelanger


On 2010-06-10 11:31:21, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/701/
> -----------------------------------------------------------
> 
> (Updated 2010-06-10 11:31:21)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> The handlers in chan_sip.c for invite and subscription requests parse the from-header twice. The first time is in check_user_full and the second time is in get_destination. This change removes the parsing from these functions and does it beforehand (with an abnf compliant parser)
> 
> 
> This addresses bug 16897.
>     https://issues.asterisk.org/view.php?id=16897
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/reqresp_parser.c 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/701/diff
> 
> 
> Testing
> -------
> 
> Compiles, runs, passes associated unit test. CID field appears correct in sip show channel 
> 
> 
> Thanks,
> 
> Nick
> 
>