[asterisk-dev] [Code Review] Kill stub files

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/695/#review2188
-----------------------------------------------------------


I set up a test using IAX2 rsa auth between two accounts. It worked w/o the patch, but after the patch we appear to be getting the stub function for ast_key_get(). I still haven't figured out why, though.


/trunk/main/Makefile
<https://reviewboard.asterisk.org/r/695/#comment4647>

    We already talked about this on Jabber and so I know you are planning on taking this out and removing adsistub.c and cryptostub.c. Just leaving this here as a reminder.


- Terry


On 2010-06-05 19:49:03, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/695/
> -----------------------------------------------------------
> 
> (Updated 2010-06-05 19:49:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Stub functions bad!  Optional_api.h good!  Me like hockey!
> 
> 
> This addresses bug 17475.
>     https://issues.asterisk.org/view.php?id=17475
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/adsi.h 268320 
>   /trunk/include/asterisk/crypto.h 268320 
>   /trunk/main/Makefile 268320 
>   /trunk/res/res_adsi.c 268320 
>   /trunk/res/res_crypto.c 268320 
> 
> Diff: https://reviewboard.asterisk.org/r/695/diff
> 
> 
> Testing
> -------
> 
> Compiles and runs.
> 
> 
> Thanks,
> 
> Tilghman
> 
>