[asterisk-dev] 0017234: [patch] Memory leak in manager.c - eqeshould never be null!

[Dave Woolley]

Tilghman Lesher wrote:
> 
> On Monday 07 June 2010 12:22:36 Dave Woolley wrote:
> > I don't believe the latest fix to issues 0017234
> > <https://issues.asterisk.org/view.php?id=17234> can have addressed
> the
> > fundamental cause of the actual crash.  That's because it is
> defending
> > against a condition that should be impossible.  session->last_ev is,
> 
> I tend to agree with your assessment, though I also cannot argue with
> evidence
> that it did, indeed, go NULL.  In fact, it appears that the event list
> was
> going empty, and the initial grab_last() was returning NULL.
> 
[[djw]] 
I'm just about to test your subsequent patch, but just for information,
without it, the event queue underflow also causes a crash in
advance_event.  Hopefully this will go away now.

For anyone testing, you need to make httptimeout as small as possible,
even if not using HTTP, to make these failures likely.

As this is a public list, the confidentiality part of the following
doesn't apply.
-- 
David Woolley
BTS Holdings Plc
Tel: +44 (0)20 8401 9000 Fax: +44 (0)20 8401 9100
http://www.bts.co.uk
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the company. If you are not the intended recipient of this email, you must take no action based upon it, nor must you copy or show it to anyone. Please contact the sender if you believe you have received this email in error. In accordance with English Law, email communications may be monitored. All reasonable precautions have been taken to ensure that no viruses are present in this email; however, the company cannot accept responsibility for loss or damage arising from the use of this email. We recommend that you subject this email to your own virus checking procedures. BTS Holdings PLC is registered in England 1517630, VAT No 523 5092 66. Registered office, BTS House, Manor Road, Wallington, SM6 0DD