[asterisk-dev] [Code Review] sip: ignore CANCEL request after having already received final response to INVITE

[Nick Lewis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/697/#review2179
-----------------------------------------------------------

Ship it!


Keep this up and before long you will have a Swedish accent

- Nick


On 2010-06-08 15:35:28, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/697/
> -----------------------------------------------------------
> 
> (Updated 2010-06-08 15:35:28)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> RFC 3261 section 9 states that a CANCEL has no effect on a request to a UAS that has already given a final response.  This patch checks to make sure there is a pending invite before allowing a CANCEL request to be processed, otherwise it responds to the CANCEL with a "481 Call/Transaction Does Not Exist".
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 269006 
> 
> Diff: https://reviewboard.asterisk.org/r/697/diff
> 
> 
> Testing
> -------
> 
> I wrote two SIPP scenarios to test this.
> 
> 1. A CANCEL is sent after the final response for an INVITE is provided.  I verified the new 481 response is given in response to the late CANCEL.
> 
> 2. A CANCEL is sent before the final response for an INVITE is provided.  I verified the invite is canceled as expected.
> 
> 
> Thanks,
> 
> David
> 
>