[asterisk-dev] [Code Review] Add new AGI command: PARK

[paul.belanger at polybeacon.com]

> On 2010-06-01 17:28:55, Mark Michelson wrote:
> > My biggest complaint about this diff is that there is no added documentation explaining how this AGI command works. This is especially needed for this command since such an odd input is needed.

Agreed.  Will try to round up some documentation.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/681/#review2125
-----------------------------------------------------------


On 2010-06-01 14:11:55, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/681/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 14:11:55)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> bklang has submitted this patch to the issue tracker, it is now flagged ready for review.
> ---
> I needed a way to programmatically park calls via AGI and return the parking slot to the script for further processing. Since the generic EXEC AGI command does not allow returning information, I created this patch which adds the PARK command to AGI. On success, the parking lot space is returned. The PARK command accepts the same arguments as the dialplan function PARK and in fact uses the same parsing code. 
> 
> 
> This addresses bug 17046.
>     https://issues.asterisk.org/view.php?id=17046
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/features.h 264538 
>   /trunk/main/features.c 264538 
>   /trunk/res/res_agi.c 264538 
> 
> Diff: https://reviewboard.asterisk.org/r/681/diff
> 
> 
> Testing
> -------
> 
> Reporter only.
> 
> 
> Thanks,
> 
> pabelanger
> 
>