[asterisk-dev] [Code Review] Automatically calculate the content-length value for sip messages.

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/693/
-----------------------------------------------------------

(Updated 2010-06-08 10:41:58.806775)


Review request for Asterisk Developers.


Changes
-------

Addressed one additional issue where the Content-Length header would be duplicated if specified in sip_notify.conf.


Summary
-------

This patch modifies chan_sip to build the body of a sip message separate from the rest of the message and then merge the body into the rest of the message all at once while automatically calculating the content-length.  It is intended to simplify the creation of sip messages and make the process less error prone.


This addresses bug 17326.
    https://issues.asterisk.org/view.php?id=17326


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 268575 
  /trunk/channels/sip/include/sip.h 268575 
  /trunk/include/asterisk/strings.h 268575 

Diff: https://reviewboard.asterisk.org/r/693/diff


Testing
-------

I ran a portion of the external test suite and monitored the sip messages that were generated using wireshark.  Everything looked correct.


Thanks,

Matthew