[asterisk-dev] [Code Review] Automatically calculate the content-length value for sip messages.

Matthew Nicholson mnicholson at digium.com
Tue Jun 8 10:41:58 CDT 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-06-08 10:41:58.806775)

Review request for Asterisk Developers.


Addressed one additional issue where the Content-Length header would be duplicated if specified in sip_notify.conf.


This patch modifies chan_sip to build the body of a sip message separate from the rest of the message and then merge the body into the rest of the message all at once while automatically calculating the content-length.  It is intended to simplify the creation of sip messages and make the process less error prone.

This addresses bug 17326.

Diffs (updated)

  /trunk/channels/chan_sip.c 268575 
  /trunk/channels/sip/include/sip.h 268575 
  /trunk/include/asterisk/strings.h 268575 

Diff: https://reviewboard.asterisk.org/r/693/diff


I ran a portion of the external test suite and monitored the sip messages that were generated using wireshark.  Everything looked correct.



More information about the asterisk-dev mailing list