[asterisk-dev] [Code Review] Add regular expression blacklist filtering for manager events

[Nick Lewis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/673/#review2170
-----------------------------------------------------------


I agree with the proposed processing order when there are both white and black filters (assuming that the output of the first process is the input to the second) but what is the behaviour when one or other type of filter is missing. Users would probably expect the following:
- no filters: implied white "all" filter
- white filters only: implied black "all" filter processed first, then white filters
- black filters only: implied white "all" filter processed first, then black filters
- white and black filters: implied black "all" filter processed first, then white filters, and lastly black filters

i.e. if there are any white filters then there is an implied black "all" filter processed first otherwise there is an implied white "all" filter processed first

- Nick


On 2010-06-03 17:37:30, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/673/
> -----------------------------------------------------------
> 
> (Updated 2010-06-03 17:37:30)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> From the submitter:
> to allow better filtering of ami-events than configuring categories, I created an option "eventfilter" for manager-users. Events to be sent are matched against regexes specified in these options and are discarded if the regex matches (blacklisting).
> 
> 
> This addresses bug 14861.
>     https://issues.asterisk.org/view.php?id=14861
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 267758 
>   /trunk/configs/manager.conf.sample 267758 
>   /trunk/main/manager.c 267758 
> 
> Diff: https://reviewboard.asterisk.org/r/673/diff
> 
> 
> Testing
> -------
> 
> I ensured manager events are reported the same without filtering and works as expected with.
> 
> 
> Thanks,
> 
> Jeff
> 
>