[asterisk-dev] [Code Review] SRTP support for Asterisk

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/191/#review2168
-----------------------------------------------------------


This concludes my full pass of this review. Over all this looks great!  I didn't find anything terribly wrong anywhere, just a few minor comments.


/trunk/channels/sip/sdp_crypto.c
<https://reviewboard.asterisk.org/r/191/#comment4624>

    chan_sip verifies that the result of this function is >= 0, but there are currently no failure conditions.  It seems like these lines deserve some sort of check for failure.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/191/#comment4625>

    Is the r channel locked during this? 



/trunk/res/res_srtp.c
<https://reviewboard.asterisk.org/r/191/#comment4626>

    Spacing is weird here, should be a tab before break; rather than spaces.



/trunk/res/res_srtp.c
<https://reviewboard.asterisk.org/r/191/#comment4627>

    This doesn't really matter, but it is kind of weird to use the AST_MODULE_LOAD_SUCCESS enum value as a result for unload_module.  Most other modules just use return 0;


- David


On 2010-06-01 21:57:09, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/191/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 21:57:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> SRTP support for Asterisk using Sdescriptions. This has been sitting around for a while, so I figured that it should at least get some review.  Full description of setup at http://lists.digium.com/pipermail/asterisk-dev/2009-January/036029.html
> 
> 
> This addresses bug 5413.
>     https://issues.asterisk.org/view.php?id=5413
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 266876 
>   /trunk/build_tools/menuselect-deps.in 266876 
>   /trunk/channels/chan_iax2.c 266876 
>   /trunk/channels/chan_sip.c 266876 
>   /trunk/channels/sip/dialplan_functions.c 266876 
>   /trunk/channels/sip/include/sdp_crypto.h PRE-CREATION 
>   /trunk/channels/sip/include/sip.h 266876 
>   /trunk/channels/sip/include/srtp.h PRE-CREATION 
>   /trunk/channels/sip/sdp_crypto.c PRE-CREATION 
>   /trunk/channels/sip/srtp.c PRE-CREATION 
>   /trunk/configure.ac 266876 
>   /trunk/funcs/func_channel.c 266876 
>   /trunk/include/asterisk/autoconfig.h.in 266876 
>   /trunk/include/asterisk/frame.h 266876 
>   /trunk/include/asterisk/global_datastores.h 266876 
>   /trunk/include/asterisk/res_srtp.h PRE-CREATION 
>   /trunk/include/asterisk/rtp_engine.h 266876 
>   /trunk/main/asterisk.exports.in 266876 
>   /trunk/main/channel.c 266876 
>   /trunk/main/global_datastores.c 266876 
>   /trunk/main/rtp_engine.c 266876 
>   /trunk/makeopts.in 266876 
>   /trunk/res/res_rtp_asterisk.c 266876 
>   /trunk/res/res_srtp.c PRE-CREATION 
>   /trunk/res/res_srtp.exports.in PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/191/diff
> 
> 
> Testing
> -------
> 
> 4 external tests written covering:
> Running with res_srtp noloaded to emulate a user not having libsrtp installed (to make sure we don't accidentally rely on SRTP support)
> Making a call with a user with encrypted=yes when libsrtp support is not enabled fails
> Making a call with encrypted=yes when libsrtp present results in an encrypted call (which also tests the CHANNEL(secure_media) function
> Using CHANNEL(secure_bridge_media) results in the outgoing call attempting to use encryption
> 
> In addition, I have tested a Polycom VVX-1500 to ensure that video + audio SRTP works.
> 
> 
> Thanks,
> 
> Terry
> 
>