[asterisk-dev] [Code Review] Initial set of Queue tests

[Mark Michelson]

> On 2010-06-04 11:58:40, David Vossel wrote:
> > /asterisk/trunk/tests/queues/macro_gosub_test/test.lua, lines 28-38
> > <https://reviewboard.asterisk.org/r/638/diff/2/?file=10434#file10434line28>
> >
> >     I don't know how the lua test framework internals work.  I am assuming wait_event will timeout after a period of time if no events are received or the manager interface never connects and return some sort of error?  As long as we are guaranteed to break out of the loop this looks okay to me.

You indeed are correct. By checking for a potential error from wait_event(), we ensure that we will not loop forever in this function.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/638/#review2147
-----------------------------------------------------------


On 2010-06-01 16:53:35, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/638/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 16:53:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A set of five queue tests.
> 
> 1. Queue Baseline: Places a call to a queue and ensures that the call goes through as expected by watching for manager events
> 2. Wrapup Time: Places calls to queue members and then ensures that the member cannot be reached during wrapuptime. Tests both regular queues and sharedlastcall instances.
> 3. Gosub/macro: Tests that macros and gosubs are executed as expected when a member answers. Tests both static configuration and overriding with parameters to the Queue application.
> 4. Ringinuse and Pause: Tests that members are not called if ringinuse=no. Ensures that autopause only takes effect if the member is attempted to be called. Ensures that paused members do not get called.
> 5. Position, Priority, and maxlen: Adds a bunch of callers to a queue and ensures that they enter at the position we expect them to.
> 
> I have ideas for about 15 more tests, but those will have to come later.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/macro_gosub_test/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/macro_gosub_test/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/position_priority_maxlen/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_baseline/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/configs/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/configs/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/sipp/uas.xml PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/ringinuse_and_pause/test.lua PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/configs/ast2/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/wrapup_time/test.lua PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/638/diff
> 
> 
> Testing
> -------
> 
> Ran the tests. They pass.
> 
> 
> Thanks,
> 
> Mark
> 
>