[asterisk-dev] [Code Review] Automatically calculate the content-length value for sip messages.

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/693/#review2149
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/693/#comment4598>

    Don't we use ast_str_buffer(s) instead of directly accessing s->str, now? s->str is used several more times.


- Terry


On 2010-06-04 12:53:46, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/693/
> -----------------------------------------------------------
> 
> (Updated 2010-06-04 12:53:46)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch modifies chan_sip to build the body of a sip message separate from the rest of the message and then merge the body into the rest of the message all at once while automatically calculating the content-length.  It is intended to simplify the creation of sip messages and make the process less error prone.
> 
> 
> This addresses bug 17326.
>     https://issues.asterisk.org/view.php?id=17326
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 267670 
>   /trunk/channels/sip/include/sip.h 267670 
> 
> Diff: https://reviewboard.asterisk.org/r/693/diff
> 
> 
> Testing
> -------
> 
> I ran a portion of the external test suite and monitored the sip messages that were generated using wireshark.  Everything looked correct.
> 
> 
> Thanks,
> 
> Matthew
> 
>