[asterisk-dev] [Code Review] RFC 3261 compliant ACK retransmission for unreliable final responses

Terry Wilson twilson at digium.com
Thu Jun 3 13:40:43 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/692/
-----------------------------------------------------------

Review request for Asterisk Developers and David Vossel.


Summary
-------

RFC 3261 in sections 13.2.24 and 17.1.1.2 state that each 2xx response or final response to an INVITE must result in an ACK being sent (but the retransmitted responses are not to be sent to the transaction user).

This patch sends that ACK.


Diffs
-----

  /trunk/channels/chan_sip.c 267137 

Diff: https://reviewboard.asterisk.org/r/692/diff


Testing
-------

I wrote a sipp scenario to re-send 200 OK responses and ensured that the proper ACK was sent back. I also tested calling a soft phone to verify that no behavior change was made when there were no retransmissions.


Thanks,

Terry




More information about the asterisk-dev mailing list