[asterisk-dev] [Code Review] Fully Booted CLI Command

Terry Wilson twilson at digium.com
Wed Jun 2 13:09:08 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/684/#review2134
-----------------------------------------------------------

Ship it!


Looks good to me.


/trunk/main/cli.c
<https://reviewboard.asterisk.org/r/684/#comment4531>

    What is the extra "" line for?


- Terry


On 2010-06-02 13:04:20, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/684/
> -----------------------------------------------------------
> 
> (Updated 2010-06-02 13:04:20)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> As discussed in the Fully Booted AMI event code review (https://reviewboard.asterisk.org/r/639/), this is a CLI command that will block until Asterisk has fully booted.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/cli.c 267092 
> 
> Diff: https://reviewboard.asterisk.org/r/684/diff
> 
> 
> Testing
> -------
> 
> Ran CLI command, behaved as expected
> 
> 
> Thanks,
> 
> Russell
> 
>




More information about the asterisk-dev mailing list