[asterisk-dev] [Code Review] Change sample slinear frame to contain non-zero data so that translation calculations for speex works

[Russell Bryant]

> On 2010-06-01 16:20:49, Russell Bryant wrote:
> > How about take one of our slinear sound prompts and use data from that instead of bogus data?
> 
> Jeff Peeler wrote:
>     I don't know how to do the conversion. Is it OK to just use the old sample data?

I'm not sure what old sample data you're talking about.  I don't care, really, as long as it's "real" audio.

As for how to do the conversion, a hex editor, or a simple program that dumps the bytes of the file out in hex for you would do.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/682/#review2124
-----------------------------------------------------------


On 2010-06-01 16:12:46, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/682/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 16:12:46)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is literally a %s/0x00/0x11/g for slin.h. The problem is that the raw data used to generate sample frames was changed to contain all zeros. When codecs.conf is configured to use both voice activity detection and preprocessing, the frames are not being returned (in lintospeex_frameout) causing the encoder to keep on trying to get more samples forever. I didn't see a good way to improve the code to be able to generate samples correctly with this "silent" data, so I changed the sample frame to contain data so voice frames were detected and passed back up.
> 
> 
> This addresses bug 17240.
>     https://issues.asterisk.org/view.php?id=17240
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/slin.h 266780 
> 
> Diff: https://reviewboard.asterisk.org/r/682/diff
> 
> 
> Testing
> -------
> 
> I tried a call using gsm (just because it's easier, also uses the data from slin.h) and it worked as expected.
> 
> 
> Thanks,
> 
> Jeff
> 
>