[asterisk-dev] [Code Review] crash in bridging api

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/679/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

fnordian submitted this patch to the issue tracker, and is marked 'Ready for Review'.
--
There's a racecondition in smart_bridge_operation(). I do not understand this function completely, but it seems like one of it's purposes is to change a bridge's technology. For doing so it stops the bridge->thread before working on it. Stopping is done by setting a flag and sending a signal. What's missing there imho is a pthread_join to assure the thread is really gone.


This addresses bug 15465.
    https://issues.asterisk.org/view.php?id=15465


Diffs
-----

  /trunk/main/bridging.c 264538 

Diff: https://reviewboard.asterisk.org/r/679/diff


Testing
-------

Users within the issue have reported success.


Thanks,

pabelanger