[asterisk-dev] [Code Review] Convert res_musiconhold to use generic timing interface

[Kevin P. Fleming]

On 07/30/2010 11:08 PM, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/826/#review2511
> -----------------------------------------------------------
> 
> 
> 
> /trunk/res/res_musiconhold.c
> <https://reviewboard.asterisk.org/r/826/#comment5536>
> 
>     ast_waitfor_n_fd() is not guaranteed to only return in the case that input is available on the timer fd.  poll() might get interrupted and return -1 with errno set to EINTR, for example.  Before ast_timer_ack() is called and this code continues, it needs to ensure that it's actually time for the timer to go off.

Yeah... this needs to be fixed in bridge_softmix.c as well. Bad Josh, no
donut!

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kfleming at digium.com
Check us out at www.digium.com & www.asterisk.org