[asterisk-dev] [Code Review] Add FIELDNUM() function which returns the position number of a field in a list.

[Tilghman Lesher]

On Friday 30 July 2010 11:10:57 Rod Dorman wrote:
> On Thursday, July 29, 2010, 22:03:54, Gareth Palmer wrote:
> > On Thu, 2010-07-29 at 15:02 -0500, Tilghman Lesher wrote:
> >> On Thursday 29 July 2010 14:51:22 Rod Dorman wrote:
> >>> Why not use a -1 to signal an error?
> >>
> >> That would be fine, as well, as long as it's documented that way.
> >
> > The problem have with returning -1 is that constructs like
> > GotoIf(${FIELDNUM(...)}?true:false) will take the 'true' path on error.
>
> That could be avoided by testing for greater than zero instead of for
> true/false
>
> One thing I'm curious about is if LIST is just "apples" what would
> ${FIELDNUM(LIST,/,apples)} return?
>
> I would argue that '1' is correct even though the delimiter isn't in
> LIST.

I don't see any reason why it wouldn't.  Have you tried it?

-- 
Tilghman Lesher
Digium, Inc. | Senior Software Developer
twitter: Corydon76 | IRC: Corydon76-dig (Freenode)
Check us out at: www.digium.com & www.asterisk.org