[asterisk-dev] [Code Review] Missing rtp changes in chan_skinny

Russell Bryant russell at digium.com
Thu Jul 29 11:24:25 CDT 2010


On Wed, 2010-07-28 at 15:05 -0700, Dan Austin wrote:
> but perhaps this line (1389, and neighbor in current trunk):
> if (audio_glue0_res == AST_RTP_GLUE_RESULT_REMOTE && (video_glue0_res == AST_RTP_GLUE_RESULT_FORBID || video_glue0_res == AST_RTP_GLUE_RESULT_REMOTE) && glue0->get_codec(c0)) {
> 
> should look like this:
> if (audio_glue0_res == AST_RTP_GLUE_RESULT_REMOTE && (video_glue0_res == AST_RTP_GLUE_RESULT_FORBID || video_glue0_res == AST_RTP_GLUE_RESULT_REMOTE) && glue0->get_codec) {

Agreed.  I'll go ahead and make that change.

-- 
Russell Bryant
Digium, Inc.  |  Engineering Manager, Open Source Software
445 Jan Davis Drive NW   -    Huntsville, AL 35806  -  USA
jabber: rbryant at digium.com    -=-    skype: russell-bryant
www.digium.com -=- www.asterisk.org -=- blogs.asterisk.org





More information about the asterisk-dev mailing list